Skip to content

chore(demo): add example for dropdownOpen #10795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

splincode
Copy link
Member

No description provided.

@splincode splincode requested a review from a team as a code owner April 11, 2025 07:44
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team April 11, 2025 07:44
Copy link

screenshot-report-bot bot commented Apr 11, 2025

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.08%. Comparing base (67993cb) to head (b6cd7b5).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10795   +/-   ##
=======================================
  Coverage   65.08%   65.08%           
=======================================
  Files        1283     1283           
  Lines       16960    16960           
  Branches     2448     2455    +7     
=======================================
  Hits        11039    11039           
+ Misses       5739     5692   -47     
- Partials      182      229   +47     
Flag Coverage Δ
summary 65.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

nx-cloud bot commented Apr 11, 2025

View your CI Pipeline Execution ↗ for commit b6cd7b5.

Command Status Duration Result
nx build icons-fontawesome ✅ Succeeded <1s View ↗
nx prebuild icons-fontawesome ✅ Succeeded 8s View ↗
nx build icons-material ✅ Succeeded 1s View ↗
nx prebuild icons-material ✅ Succeeded 31s View ↗
nx build icons ✅ Succeeded <1s View ↗
nx prebuild icons ✅ Succeeded 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-11 08:04:36 UTC

Copy link

nx-cloud bot commented Apr 11, 2025

View your CI Pipeline Execution ↗ for commit b6cd7b5.

Command Status Duration Result
nx run-many --target build --all --exclude=demo... ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-11 07:46:44 UTC

Copy link
Contributor

Visit the preview URL for this PR (updated for commit b6cd7b5):

https://taiga-previews-demo--pr10795-splincode-chore-demo-demo-hp23ck0x.web.app

(expires Sat, 12 Apr 2025 07:48:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Apr 11, 2025

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
49.08KB (+23B +0.05%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
320.61KB +10%
demo/browser/vendor.(hash).js
260.79KB +10%
demo/browser/styles.(hash).css
21.17KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +23B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
8.54MB (+6.46KB +0.07%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

Playwright test results

failed  3 failed
passed  1117 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  1121 tests across 74 suites
duration  10 minutes, 32 seconds
commit  b6cd7b5

Failed tests

chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Hosted dropdown
chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Hosted dropdown and custom position
chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › late init control binding

Skipped tests

chromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with select

@waterplea
Copy link
Member

First example of dropdown open already implements let-close and had the issue reproducible

@waterplea waterplea closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants