-
Notifications
You must be signed in to change notification settings - Fork 523
feat(addon-doc): hide fullscreen button when device doesn't support fullscreen API #10800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
splincode
commented
Apr 11, 2025
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
View your CI Pipeline Execution ↗ for commit 5ee54ef.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10800 +/- ##
==========================================
- Coverage 65.08% 65.08% -0.01%
==========================================
Files 1283 1283
Lines 16962 16963 +1
Branches 2482 2463 -19
==========================================
Hits 11040 11040
- Misses 5612 5726 +114
+ Partials 310 197 -113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Visit the preview URL for this PR (updated for commit 5ee54ef): https://taiga-previews-demo--pr10800-splincode-doc-demo-7ch9vp5x.web.app (expires Sat, 12 Apr 2025 13:58:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +41B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test resultsDetails
Skipped testschromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with select |
Maybe add fullscreen for API page too? Just an idea) |