Skip to content

feat(addon-doc): hide fullscreen button when device doesn't support fullscreen API #10800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025

Conversation

splincode
Copy link
Member

image

@splincode splincode requested a review from a team as a code owner April 11, 2025 13:54
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team April 11, 2025 13:54
Copy link

screenshot-report-bot bot commented Apr 11, 2025

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

nx-cloud bot commented Apr 11, 2025

View your CI Pipeline Execution ↗ for commit 5ee54ef.

Command Status Duration Result
nx run-many --target test --all --output-style=... ✅ Succeeded 33s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-11 14:13:34 UTC

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.08%. Comparing base (fdf3ac0) to head (5ee54ef).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../addon-doc/components/example/example.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10800      +/-   ##
==========================================
- Coverage   65.08%   65.08%   -0.01%     
==========================================
  Files        1283     1283              
  Lines       16962    16963       +1     
  Branches     2482     2463      -19     
==========================================
  Hits        11040    11040              
- Misses       5612     5726     +114     
+ Partials      310      197     -113     
Flag Coverage Δ
summary 65.08% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 5ee54ef):

https://taiga-previews-demo--pr10800-splincode-doc-demo-7ch9vp5x.web.app

(expires Sat, 12 Apr 2025 13:58:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Apr 11, 2025

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
320.7KB (+40B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.79KB +10%
demo/browser/runtime.(hash).js
49.05KB +10%
demo/browser/styles.(hash).css
21.17KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +41B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
8.54MB (+53B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

Playwright test results

passed  1120 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  1121 tests across 74 suites
duration  10 minutes, 15 seconds
commit  5ee54ef

Skipped tests

chromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with select

@mdlufy
Copy link
Collaborator

mdlufy commented Apr 11, 2025

Maybe add fullscreen for API page too? Just an idea)

@splincode splincode merged commit 9c3b5f8 into main Apr 13, 2025
29 checks passed
@splincode splincode deleted the splincode/doc branch April 13, 2025 18:23
aasereb7 pushed a commit to aasereb7/taiga-ui that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants