fix(kv_storage): handle cache clearing with regular files#3343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix cache clearing to handle directories that contain regular files (e.g.
.mcp.json) alongside cacache-managed entries.Context
cacache::clearinternally callsremove_dir_allon every entry within the cache directory. When regular files (such as.mcp.json) are present alongside cacache-managed subdirectories, this fails withENOTDIRbecause it tries to treat those files as directories.The fix replaces
cacache::clearwith a simpler and more robust approach: remove the entire cache directory and immediately recreate it.Changes
cacache::clearwithtokio::fs::remove_dir_all+tokio::fs::create_dir_allinCacacheStorage::clearKey Implementation Details
cacache::cleariterates over entries in the cache dir and callsremove_dir_allon each one, which fails when it encounters plain files. Removing the whole directory and recreating it avoids this entirely and is equivalent in effect — the cache is fully cleared and ready to accept new entries.Testing
Links