Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The existing table-specific toolbar owns both DataTable controls and their layout. That prevents the same interaction model from serving other action bars and forces consumers into a fixed placement model.
This change introduces a reusable full-width Toolbar and demonstrates it in standalone and DataTable list-screen scenarios.
Design Decision
Explicit layout structure
Toolbar.Rootstacks horizontal rows. EachToolbar.Rowcontains relatedToolbar.Groupcontrols and optional separators;justify="between"places the row's leading and trailing groups at opposite edges without special end-slot APIs.Seamless control participation
AppShell Button, Input, Select, Combobox, and Tabs controls register their focus target through the row context. Plain controls participate in row-level Arrow/Home/End navigation, while composite controls keep their own directional-key behavior.
DataTable composition
DataTable.ColumnSettingsis now placeable. A generic Toolbar directly insideDataTable.Rootbecomes the table's top bar: its side/top borders are removed while its top corners and bottom divider are retained.Summary
Toolbarcomponent, its documentation, tests, and a runnable example page.DataTable.ColumnSettings.