Update cache dependencies#22
Merged
creachadair merged 1 commit intoJul 13, 2026
Merged
Conversation
Use the released atomicfile fix and the merged gocache integrity fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
gocacheandatomicfileto include the cache-integrity fixes merged upstream.I found these while investigating a corrupted entry served by our remote Go build cache in CI, which uses
go-cache-plugin. The S3 objects I sampled were intact, so I traced possible corruption paths through the plugin's runner-local staging layer.The
gocacheupdate includes creachadair/gocache#6. A short S3 response ending witha clean EOF previously could be committed to the local cache with its shorter actual size, then later returned as a valid cache hit.
gocachenow verifies the copied size against the object's declared size before publishing it.The
atomicfileupdate includes creachadair/atomicfile#1.WriteAllnow aborts its transaction on an explicit input read error and reports close or rename failures, instead of potentially publishing a partial file while returning an error to the caller.