Skip to content

Update cache dependencies#22

Merged
creachadair merged 1 commit into
tailscale:mainfrom
Blue-Water-Autonomy:update-cache-dependencies
Jul 13, 2026
Merged

Update cache dependencies#22
creachadair merged 1 commit into
tailscale:mainfrom
Blue-Water-Autonomy:update-cache-dependencies

Conversation

@AdamVig

@AdamVig AdamVig commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Update gocache and atomicfile to include the cache-integrity fixes merged upstream.

I found these while investigating a corrupted entry served by our remote Go build cache in CI, which uses go-cache-plugin. The S3 objects I sampled were intact, so I traced possible corruption paths through the plugin's runner-local staging layer.

The gocache update includes creachadair/gocache#6. A short S3 response ending with
a clean EOF previously could be committed to the local cache with its shorter actual size, then later returned as a valid cache hit. gocache now verifies the copied size against the object's declared size before publishing it.

The atomicfile update includes creachadair/atomicfile#1. WriteAll now aborts its transaction on an explicit input read error and reports close or rename failures, instead of potentially publishing a partial file while returning an error to the caller.

Use the released atomicfile fix and the merged gocache integrity fix.
@creachadair
creachadair merged commit def63db into tailscale:main Jul 13, 2026
1 check passed
@AdamVig
AdamVig deleted the update-cache-dependencies branch July 13, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants