checkInteractive was crashing
#119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`checkInteractive` was crashing when a modal was over the list and it was pressed a _ctrl key_ like (command or ctrl). I am using MUI. I don't know if it happens with other modals. But the `while` in `checkInteractive` was going up until it get to the _html tag_ and it was breaking the `.getAttribute` This was only happening in chromium browsers
|
tajo
reviewed
May 13, 2025
| @@ -123,6 +123,12 @@ export function checkIfInteractive(target: Element, rootElement: Element) { | |||
| if (!target || !rootElement) return false; | |||
|
|
|||
| while (target !== rootElement) { | |||
| if (!target) { | |||
| return false; | |||
There was a problem hiding this comment.
this is a redundant check, we do it right above this line
|
lint needs to be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkInteractivewas crashing when a modal was over the list and it was pressed a ctrl key like (command or ctrl).I am using MUI. I don't know if it happens with other modals.
But the
whileincheckInteractivewas going up until it get to the html tag and it was breaking the.getAttributeThis was only happening in chromium browsers.Thanks