Bugfix/tel split#16
Open
guidfort wants to merge 13 commits into
Open
Conversation
Sip Exception
set Logging
set Logging
tammon
requested changes
Jan 22, 2019
tammon
left a comment
tammon
left a comment
Owner
There was a problem hiding this comment.
Some things need to be changed in this pull request before merging.
All in all I have the feeling that this library needs major refactoring for easier extensibility and stability. There's too much shit in this class. I'll try to adress this problem in a future v1.0
Owner
|
duplicate PR to #18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.