Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ribbon Fixes #764

Merged
merged 9 commits into from
Apr 8, 2025
Merged

Ribbon Fixes #764

merged 9 commits into from
Apr 8, 2025

Conversation

Adamtaranto
Copy link
Collaborator

Update add_option method to add_argument.

Restore missing opt --extra-annotation to plot secondary anntation track.

Add debug logs

@Adamtaranto Adamtaranto marked this pull request as draft April 1, 2025 12:16
@Adamtaranto Adamtaranto changed the title Fix multi track plotting WIP: Ribbon Fixes Apr 1, 2025
@Adamtaranto Adamtaranto self-assigned this Apr 6, 2025
@Adamtaranto Adamtaranto added the bug label Apr 6, 2025
@Adamtaranto
Copy link
Collaborator Author

Ready for review.

Ribbon module is working again after updating arg handling to use argparse following changes to jcvi.apps.base

Added option to add a second custom annotation track with --extra-annotations

@Adamtaranto Adamtaranto marked this pull request as ready for review April 6, 2025 09:02
@Adamtaranto Adamtaranto requested a review from tanghaibao April 6, 2025 09:03
@Adamtaranto Adamtaranto changed the title WIP: Ribbon Fixes Ribbon Fixes Apr 6, 2025
@Adamtaranto Adamtaranto merged commit bd79635 into main Apr 8, 2025
@Adamtaranto Adamtaranto deleted the ribbon_fixes branch April 8, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant