[WIP] Unit tests/basics #28
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdralexandru
requested review from
ateslovan,
catadarjan-tapptitude and
laurentiuonac
and removed request for
ateslovan and
laurentiuonac
catadarjan-tapptitude
approved these changes
Feb 1, 2023
catadarjan-tapptitude
left a comment
catadarjan-tapptitude
left a comment
There was a problem hiding this comment.
Nice :D
- with just some small comments
| class LoadImageUseCase internal constructor(private val imageRepository: ImageRepository) { | ||
| class LoadImageUseCase constructor(private val imageRepository: ImageRepository) { | ||
|
|
||
| suspend fun invoke(): Image = imageRepository.getRandomImage() |
There was a problem hiding this comment.
Shouldn't it also have the operator modifier? 🤔
| ) : ViewModel() { | ||
| private val _isLoading = MutableLiveData<Boolean>() | ||
| private val _isLoading = MutableLiveData<Boolean>(false) | ||
| val isLoading: LiveData<Boolean> = _isLoading |
There was a problem hiding this comment.
I think this is supposed to have a getter instead of assigned MutableLiveData value, right?
| import kotlinx.coroutines.flow.StateFlow | ||
|
|
||
| internal class FakeSessionManager : SessionManager { | ||
| private val _currentLoginStateFlow: MutableStateFlow<LoginState> = MutableStateFlow( |
There was a problem hiding this comment.
What's the Hard Wrap setting value in your Android Studio? I think anything under ~120 is a bit too short
| * No need to create an instance of retrofit | ||
| */ | ||
| internal class SessionInterceptorTest { | ||
| private lateinit var interceptor: SessionInterceptor |
There was a problem hiding this comment.
I prefer leaving an empty line between class declaration and first field/method. Makes it feel a bit cleaner :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A a few Unit Test