-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a workflow for TARDIS High energy #2998
base: master
Are you sure you want to change the base?
Created a workflow for TARDIS High energy #2998
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
*beep* *bop* 16 W293 [*] Blank line contains whitespace
5 F401 [*] `astropy.constants` imported but unused
3 W291 [*] Trailing whitespace
2 I001 [*] Import block is un-sorted or un-formatted
Complete output(might be large): docs/workflow_notebook.ipynb:cell 1:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/workflows/tardis_he_workflow.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/workflows/tardis_he_workflow.py:2:17: F401 [*] `numpy` imported but unused
tardis/workflows/tardis_he_workflow.py:3:18: F401 [*] `pandas` imported but unused
tardis/workflows/tardis_he_workflow.py:4:25: F401 [*] `astropy.units` imported but unused
tardis/workflows/tardis_he_workflow.py:5:29: F401 [*] `astropy.constants` imported but unused
tardis/workflows/tardis_he_workflow.py:7:47: F401 [*] `tardis.energy_input.energy_source.get_nuclear_lines_database` imported but unused
tardis/workflows/tardis_he_workflow.py:71:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:82:1: W293 Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:91:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:101:1: W293 Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:105:90: W291 Trailing whitespace
tardis/workflows/tardis_he_workflow.py:110:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:123:1: W293 Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:130:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:135:1: W293 Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:165:54: W291 [*] Trailing whitespace
tardis/workflows/tardis_he_workflow.py:166:64: W291 [*] Trailing whitespace
tardis/workflows/tardis_he_workflow.py:171:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:176:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:180:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:182:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:184:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:188:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:192:1: W293 [*] Blank line contains whitespace
tardis/workflows/tardis_he_workflow.py:196:1: W293 [*] Blank line contains whitespace
Found 26 errors.
[*] 21 fixable with the `--fix` option (5 hidden fixes can be enabled with the `--unsafe-fixes` option).
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
- Coverage 70.01% 69.46% -0.55%
==========================================
Files 228 229 +1
Lines 16549 16597 +48
==========================================
- Hits 11586 11529 -57
- Misses 4963 5068 +105 ☔ View full report in Codecov by Sentry. |
*beep* *bop* Hi, human. The Click here to see your results. |
*beep* *bop* Significantly changed benchmarks: All benchmarks: Benchmarks that have stayed the same:
| Change | Before [a51af908] <master> | After [8ae0a3e2] | Ratio | Benchmark (Parameter) |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
| | 25.2±6μs | 32.4±9μs | ~1.28 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
| | 1.78±0.05ms | 2.22±0.08ms | ~1.25 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop |
| | 2.56±1μs | 2.01±1μs | ~0.79 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators |
| | 8.26±1ms | 6.46±0.03ms | ~0.78 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') |
| | 9.58±1μs | 7.42±0.6μs | ~0.78 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket |
| | 852±100ns | 511±100ns | ~0.60 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation |
| | 641±100ns | 701±200ns | 1.09 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation |
| | 3.89±0.6μs | 4.21±0.6μs | 1.08 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell |
| | 1.56±0.6μs | 1.64±0.4μs | 1.05 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line |
| | 53.8±50μs | 56.7±30μs | 1.05 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter |
| | 681±100ns | 691±100ns | 1.01 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation |
| | 3.05±0.04ms | 3.09±0.03ms | 1.01 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') |
| | 45.3±0s | 45.8±0.8s | 1.01 | run_tardis.BenchmarkRunTardis.time_run_tardis |
| | 1.27±0m | 1.29±0.01m | 1.01 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking |
| | 43.7±20μs | 44.3±30μs | 1.01 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission |
| | 759±2ns | 756±3ns | 1.00 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter |
| | 2.21±0m | 2.20±0m | 0.99 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions |
| | 212±0.09ns | 209±0.4ns | 0.99 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body |
| | 1.29±0.01μs | 1.25±0.02μs | 0.97 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary |
| | 38.8±0.3μs | 37.2±0.07μs | 0.96 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list |
| | 3.98±0.2μs | 3.78±0.3μs | 0.95 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket |
| | 68.7±0.9ms | 64.9±0.4ms | 0.94 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe |
| | 9.16±3μs | 8.64±2μs | 0.94 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley |
| | 5.70±1ms | 5.22±0.9ms | 0.92 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop |
If you want to see the graph of the results, you can check it here |
📝 Description
Type: 🚀
feature
|This is a workflow created for the high energy module of TARDIS.
📌 Resources
Notebook added