Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Scale connect status before acquiring lock #34

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

arpal7
Copy link
Contributor

@arpal7 arpal7 commented Feb 6, 2024

Description of changes:
Fix scale non immediate timeout when there is not scale

Description of testing:
Tested on non scale register with weighted item - Timeout happened immediately - PASS
Please make sure the following changes have been made before creating a pull request.

Update Description

  • Change tested on actual device
  • Changes tested for simulator
  • Existing device functionality is working fine
  • Unit Tests Written for Code Changes, and Verified that Coverage is 100% for Modified Files(with the exception of ATM devices)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


arnab seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@arpal7 arpal7 marked this pull request as draft February 6, 2024 17:19
@arpal7 arpal7 marked this pull request as ready for review February 14, 2024 21:14
Copy link
Collaborator

@LizZhang-00 LizZhang-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Marker

@arpal7 arpal7 merged commit 0a213c1 into main Feb 14, 2024
@arpal7 arpal7 deleted the nonScale_changes branch February 14, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants