Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printer lock stuck #36

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Fix printer lock stuck #36

merged 4 commits into from
Feb 22, 2024

Conversation

rrenkor
Copy link
Collaborator

@rrenkor rrenkor commented Feb 22, 2024

Description of changes:

  • Fix lock getting stuck on if printer enable fails

Description of testing:

  • Unit tests verify that unlock occurs if enable throws exception
  • Put printer into bad state and attempt multiple prints, verify that printer isn't already locked

Please make sure the following changes have been made before creating a pull request.

Update Description

  • Change tested on actual device
  • Changes tested for simulator
  • Existing device functionality is working fine
  • Unit Tests Written for Code Changes, and Verified that Coverage is 100% for Modified Files(with the exception of ATM devices)

@rrenkor rrenkor requested a review from arpal7 as a code owner February 22, 2024 17:12
@rrenkor rrenkor merged commit 45fea52 into main Feb 22, 2024
1 check passed
@rrenkor rrenkor deleted the fixPrinterLockStuck branch February 22, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants