Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner Health Temporary Revert #44

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Scanner Health Temporary Revert #44

merged 2 commits into from
Jun 25, 2024

Conversation

bmcecilia3
Copy link
Collaborator

@bmcecilia3 bmcecilia3 commented Jun 25, 2024

Description of changes:

  • Revert scanner health changes temporarily

Description of testing:
Tested to ensure scanner functionality

Please make sure the following changes have been made before creating a pull request.

Update Description

  • Change tested on actual device
  • Changes tested for simulator
  • Existing device functionality is working fine
  • Unit Tests Written for Code Changes, and Verified that Coverage is 100% for Modified Files(with the exception of ATM devices)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Bernadette seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bmcecilia3 bmcecilia3 marked this pull request as ready for review June 25, 2024 15:35
@bmcecilia3 bmcecilia3 requested a review from arpal7 as a code owner June 25, 2024 15:35
Copy link
Collaborator

@LizZhang-00 LizZhang-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore your test case instead of commenting out.

@bmcecilia3 bmcecilia3 merged commit 14dd997 into main Jun 25, 2024
1 check was pending
@bmcecilia3 bmcecilia3 deleted the scanner_health_revert branch June 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants