Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Scanner Name in Peripherals Endpoint #46

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Check for Scanner Name in Peripherals Endpoint #46

merged 5 commits into from
Jul 30, 2024

Conversation

bmcecilia3
Copy link
Collaborator

@bmcecilia3 bmcecilia3 commented Jul 30, 2024

Description of changes:

  • added a check for the scanner device name to get accurate health calls for POSCentral

Description of testing:

  • Tested on T9401REG0066 for functionality

Please make sure the following changes have been made before creating a pull request.

Update Description

  • Change tested on actual device
  • Changes tested for simulator
  • Existing device functionality is working fine
  • Unit Tests Written for Code Changes, and Verified that Coverage is 100% for Modified Files(with the exception of ATM devices)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Bernadette seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bmcecilia3 bmcecilia3 changed the title Pna 2146 Check for Scanner Name in Peripherals Endpoint Jul 30, 2024
@bmcecilia3 bmcecilia3 marked this pull request as ready for review July 30, 2024 15:27
@bmcecilia3 bmcecilia3 requested a review from arpal7 as a code owner July 30, 2024 15:27
@bmcecilia3 bmcecilia3 merged commit 8551ba0 into main Jul 30, 2024
1 check was pending
@bmcecilia3 bmcecilia3 deleted the PNA-2146 branch July 30, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants