Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring update #7

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Spring update #7

merged 4 commits into from
Oct 4, 2023

Conversation

arpal7
Copy link
Contributor

@arpal7 arpal7 commented Sep 26, 2023

Description of changes:
Update project to Java-17, Spring boot 3.1.4

Description of testing:
Tested on lab registers and with simulator, works fine.

Please make sure the following changes have been made before creating a pull request.

Update Description

  • Change tested on actual device
  • Changes tested for simulator
  • Existing device functionality is working fine
  • Unit Tests Written for Code Changes, and Verified that Coverage is 100% for Modified Files(with the exception of ATM devices)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


arnab seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@arpal7 arpal7 marked this pull request as draft October 1, 2023 03:26
@arpal7 arpal7 marked this pull request as ready for review October 2, 2023 17:48
Copy link
Collaborator

@venkateshrajmendram venkateshrajmendram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@bmcecilia3 bmcecilia3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a description of testing done before merging as per "Description of Changes" comment.

@arpal7 arpal7 requested review from bmcecilia3 and rrenkor October 4, 2023 13:52
@arpal7 arpal7 requested review from venkateshrajmendram and ajnawrocki and removed request for venkateshrajmendram October 4, 2023 15:26
@arpal7 arpal7 merged commit d1a6e64 into main Oct 4, 2023
@arpal7 arpal7 deleted the java17_update branch October 4, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants