dev: switch to go tool for most tools
#4330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6...v7) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
… better consistency
… integration tests
…hout error return
…fy resource closure
…-7' into sqlc-go-tool
…bsolete devtools package
# Conflicts: # Makefile # go.mod # go.sum
KatieMSB
previously approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Switches to using
go toolfrom the combination of make targets andgo runpaths.bin/<tool>,bin/tools/<tool>,go run ...withgo tool <tool>toolmetapathgo install tool(which builds binaries for ALL defined tools and places them inGOBINsqlcto be version tracked viago.modand used viago toolrather than manually downloading the binarytool.gonow that everything is managed viago toolgo:generatecommands to usego toolremoving the need to do relative pathsgo tool