Draft
Conversation
Contributor
Author
|
This still needs tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds blame functionality to proof batch verification, offering either single or full failure identification. In each case, the verifier first attempts to verify a complete batch. Subsequent behavior depends on the caller's requirements.
After initial failure using
RangeProof::verify_batch_with_first_blame, the verifier performs a binary search to identify the first failing proof in the batch, providing its index. This requires a number of batch verifications that is logarithmic in the batch size; each subsequent verification cuts the number of proofs in the batch by half.After initial failure using
RangeProof::verify_batch_with_full_blame, the verifier attempts to verify each proof in the batch, providing a list of indexes of all failing proofs. This requires a number of non-batch verifications that is linear in the batch size.This supersedes tari-project/tari-crypto#224.