Skip to content
This repository has been archived by the owner on Feb 20, 2020. It is now read-only.

look for tooltool in the new location #194

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

djmitche
Copy link
Contributor

@djmitche djmitche requested a review from petemoore April 24, 2019 20:42
@djmitche
Copy link
Contributor Author

Oh, and worth noting, that this built an image without complaining that the URL download failed, leading to https://tools.taskcluster.net/groups/fmtw81BoQsGNPQG3XCvWPw/tasks/fmtw81BoQsGNPQG3XCvWPw/runs/0/logs/public%2Flogs%2Flive.log -- it would be great if image building failed when a download failed!

Copy link
Member

@petemoore petemoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petemoore
Copy link
Member

Oh, and worth noting, that this built an image without complaining that the URL download failed, leading to https://tools.taskcluster.net/groups/fmtw81BoQsGNPQG3XCvWPw/tasks/fmtw81BoQsGNPQG3XCvWPw/runs/0/logs/public%2Flogs%2Flive.log -- it would be great if image building failed when a download failed!

I think the best way for us to handle this will be in RFC 122. With the current machine image creation mechanics, there is no easy way to signal that a shutdown instance shouldn't be used, since the worker_type.sh script simply waits for the instance to be in shutdown state before snapshotting it to create the machine image. There isn't something like an exit code that it can check first. However with RFC 122 the image creation will be a taskcluster task itself, which will have a resolution (successful, failed, exception) and we'll have a log of the image setup as a taskcluster artifact too, so failure-handling will be much simpler.

@petemoore petemoore merged commit 40d626b into taskcluster:master Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants