Fix: Handle Ruby 3.4 caller format in ResourceScenario#treeSum (#300) #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uggler#300) Ruby 3.4.0 changed the output format of \`caller\`, potentially omitting quotes around method names. The previous code in ResourceScenario#treeSum relied on a regex (\`/''.*''/\`) that expected these quotes. When the regex failed to match on Ruby 3.4, it returned nil, leading to a fatal \`undefined method ''[]'' for nil\` error when generating cache tags. This change introduces a check for Ruby version >= 3.4.0. For these versions, it attempts to parse the method name using a more flexible regex (\`/in\s+\`?([^''\`\s]+)''?/\`) that handles optional quotes. Crucially, a fallback mechanism is added. If parsing the method name still fails (which can happen if the caller format is unexpected, producing warnings), it generates a cache tag using a hash of the raw caller string. This prevents the fatal error and allows TaskJuggler to run, albeit potentially with less optimal caching in those specific edge cases. Fixes taskjuggler#300
Member
|
The example you've posted in #300 works fine for me with the latest TJ git version. Can you post the output of caller() with a TJ3 + Ruby 3.4 that does not work with the latest git version, please? |
|
hello, thanks for the update. Can you also update the version so that it is in the official release. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.4.0 changed the output format of
caller, potentially omittingquotes around method names. The previous code in ResourceScenario#treeSum
relied on a regex (
/'(.*)'/) that expected these quotes. When the regexfailed to match on Ruby 3.4, it returned nil, leading to a fatal
undefined method '[]' for nilerror when generating cache tags.This change introduces a check for Ruby version >= 3.4.0. For these
versions, it attempts to parse the method name using a more flexible
regex (
/in\s+\?([^'\`\s]+)'?/) that handles optional quotes.Crucially, a fallback mechanism is added. If parsing the method name
still fails (which can happen if the caller format is unexpected,
producing warnings), it generates a cache tag using a hash of the
raw caller string. This prevents the fatal error and allows TaskJuggler
to run, albeit potentially with less optimal caching in those specific
edge cases.
Fixes #300