-
Notifications
You must be signed in to change notification settings - Fork 36
연락처 관리 앱 [STEP3] Howard,Mond #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JEON-Sungsu
wants to merge
13
commits into
tasty-code:2_Howard
Choose a base branch
from
JEON-Sungsu:main
base: 2_Howard
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d43f4c2
chore: merge step2 into step3
JEON-Sungsu 25d68ff
feat: 연락처 swipe cell 삭제
ddcbce1
feat: 커스텀Cell 추가
JEON-Sungsu e30a26b
step2 merge into step3
JEON-Sungsu 7278ff9
feat: Dynamic Type 적용
9f02ea5
feat: Dynamic type 추가 수정
JEON-Sungsu b8135e6
feat: 연락처 검색 기능 추가
JEON-Sungsu e00c299
refactor: private 키워드 추가, tableView함수 수정
JEON-Sungsu 26c5f75
Merge pull request #6 from JEON-Sungsu/step3
JEON-Sungsu ccacfe0
Update README.md
JEON-Sungsu 9a08713
refactor: Custom TableView Cell 파일 이름 변경, 함수 삭제
0689044
refactor: cell 그리기 분리
7f44d51
Merge pull request #7 from JEON-Sungsu/step3
JEON-Sungsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+1.79 KB
(100%)
...odeproj/project.xcworkspace/xcuserdata/howardj.xcuserdatad/UserInterfaceState.xcuserstate
Binary file not shown.
21 changes: 21 additions & 0 deletions
21
ContactManager/ContactManager/Controller/ContactInformationTableViewCell.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // | ||
| // CustomTableViewCell.swift | ||
| // ContactManager | ||
| // | ||
| // Created by 전성수 on 10/17/23. | ||
| // | ||
|
|
||
| import UIKit | ||
|
|
||
| class ContactInformationTableViewCell: UITableViewCell { | ||
|
|
||
| @IBOutlet weak var name: UILabel! | ||
| @IBOutlet weak var age: UILabel! | ||
| @IBOutlet weak var digits: UILabel! | ||
|
|
||
| func drawCell(_ person: Person) { | ||
| self.name.text = person.name | ||
| self.age.text = person.age | ||
| self.digits.text = person.digits | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 searchFilteredList를 놔두는 것도 괜찮지만, 추후에 코드들이 많아지면 복잡해질 수 있습니다.
기존 연락처와 같이 데이터들을 관리할 객체를 생성해서 처리하는건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 부분은 오늘 시간이 부족해서 완료하지 못했습니다. 새로 알게된 문제가 하나 있었는데, 검색을 통해서 나온 리스트를 삭제했을 때, 문제가 발생하더라구요.. 그래서 말씀해주신대로 따로 객체를 생성해서 처리하면 이부분도 해결될 것 같다 라고 생각했는데, 일단.. 오늘은 시간이 부족해서 이후에 다시 만들어서 해보도록 하겠습니다!