Adapt ToIntlMathematicalValue to handle initial numeric-like text
#73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
intl.emu
Outdated
| 1. Perform ? RequireInternalSlot(_O_, [[Decimal128Data]]). | ||
| 1. Perform ? RequireInternalSlot(_O_, [[Value]]). | ||
| 1. Let _amountUnit_ be _O_.[[Unit]]. | ||
| 1. Let _optionsUnit_ be _options_.[[unit]]. |
Member
There was a problem hiding this comment.
This is reading an internal slot?
Collaborator
Author
There was a problem hiding this comment.
I've updated things so that we no longer refer to an internal slot and, if necessary, create a fresh copy of options rather than potentially modifying it.
Use the `Get` and `Set` AOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we make
ToIntlMathematicalValueact essentially likeparseFloat, which allows it to handle an initial numeric string optionally followed by text like[kg]or[meter-per-second]. It's not specific to the format we have in mind for marking numeric strings with a unit.