forked from opensearch-project/OpenSearch
-
Notifications
You must be signed in to change notification settings - Fork 0
Testing #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avb-is-me
wants to merge
543
commits into
team-dev-docs:main
Choose a base branch
from
opensearch-project:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Testing #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close #2341 Signed-off-by: Levi Zim <[email protected]>
Signed-off-by: Ashish Singh <[email protected]>
* Fix object field exists query Signed-off-by: panguixin <[email protected]> * catch uoe Signed-off-by: panguixin <[email protected]> * changelog Signed-off-by: panguixin <[email protected]> --------- Signed-off-by: panguixin <[email protected]> Signed-off-by: Marc Handalian <[email protected]> Co-authored-by: Marc Handalian <[email protected]>
) Signed-off-by: Bo Zhang <[email protected]>
(cherry picked from commit 47f9bdb) Signed-off-by: Rajat Gupta <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Rajat Gupta <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
…8185) Signed-off-by: Swetha Guptha <[email protected]> Co-authored-by: Swetha Guptha <[email protected]>
* Add bwc version 2.19.3 Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Andrew Ross <[email protected]> * Fix version id Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
* Use Bad Request status for InputCoercionException Signed-off-by: Daniel Widdis <[email protected]> * Add yamlRestTest for the fix Signed-off-by: Daniel Widdis <[email protected]> * Skip test before 3.1.0 Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
…finiteLoop (#18199) Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
* Fix seccomp test Signed-off-by: Rajat Gupta <[email protected]> * Remove sudo su for seccomp test Signed-off-by: Rajat Gupta <[email protected]> --------- Signed-off-by: Rajat Gupta <[email protected]> Co-authored-by: Rajat Gupta <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
* Null check field names in QueryStringQuerybuilder Signed-off-by: Daniel Widdis <[email protected]> * Restrict test to run on >=3.1.0 Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
…d() (#18204) * Fix flakiness in testClosingShard() Signed-off-by: Peter Alfonsi <[email protected]> * Update modules/cache-common/src/internalClusterTest/java/org/opensearch/cache/common/tier/TieredSpilloverCacheStatsIT.java Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
…eSystemProvider.class (#17989) * Increased the scope o File Interceptor ro intercept methods from FileSystemProvider.class Signed-off-by: Pranav Reddy <[email protected]> * Added negative Integ Tests to validate the correct Security Exception being thrown Signed-off-by: Pranav Reddy <[email protected]> * Fixed failing negative tests because of file exist assertions Signed-off-by: Pranav Reddy <[email protected]> * Added a deny default Security Exception for unknown arfumen types in File Interceptor Signed-off-by: Pranav Reddy <[email protected]> * Fixed File Permission substitution for Integ test Log files Signed-off-by: Pranav Reddy <[email protected]> * Fixes issue with system property substition in policy file parsing Signed-off-by: Pranav Reddy <[email protected]> * Added ChangeLog for newByteChannel Interception Signed-off-by: Pranav Reddy <[email protected]> --------- Signed-off-by: Pranav Reddy <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
…t) (#18193) Signed-off-by: Andriy Redko <[email protected]>
…shold for approximated match_all queries (#18189) Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
…in /plugins/repository-hdfs (#18103) * Bump org.apache.commons:commons-configuration2 Bumps org.apache.commons:commons-configuration2 from 2.11.0 to 2.12.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-configuration2 dependency-version: 2.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…finiteLoop (#18209) Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
…ository-azure (#18104) * Bump com.nimbusds:nimbus-jose-jwt in /plugins/repository-azure Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 10.0.2 to 10.2. - [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.2..10.0.2) --- updated-dependencies: - dependency-name: com.nimbusds:nimbus-jose-jwt dependency-version: '10.2' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> * Fix thirdPartyAudit Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <[email protected]>
…ixtures/hdfs-fixture (#18102) * Bump org.apache.commons:commons-text in /test/fixtures/hdfs-fixture Bumps org.apache.commons:commons-text from 1.13.0 to 1.13.1. --- updated-dependencies: - dependency-name: org.apache.commons:commons-text dependency-version: 1.13.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <[email protected]>
* Make extended plugins optional Signed-off-by: Craig Perkins <[email protected]> * Make extended plugins optional Signed-off-by: Craig Perkins <[email protected]> * Load extensions for classpath plugins Signed-off-by: Craig Perkins <[email protected]> * Ensure only single instance for each classpath extension Signed-off-by: Craig Perkins <[email protected]> * Add test for classpath plugin extended plugin loading Signed-off-by: Craig Perkins <[email protected]> * Enable testing for ExtensiblePlugins using classpath plugins Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Define PluginInfos from test files for classpath plugins Signed-off-by: Craig Perkins <[email protected]> * Add testing constructor for PluginsService Signed-off-by: Craig Perkins <[email protected]> * Single call to loadExtensions Signed-off-by: Craig Perkins <[email protected]> * Reduce number of MockNode constructors Signed-off-by: Craig Perkins <[email protected]> * Create 2 public constructors for MockNode Signed-off-by: Craig Perkins <[email protected]> * Update import Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> * Fix logic Signed-off-by: Craig Perkins <[email protected]> * Address PR feedback Signed-off-by: Craig Perkins <[email protected]> * Rename variables Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
…ous type of field mappers (#17759) * Adding support for derive source feature and implementing it for some of the field types Signed-off-by: Tanik Pansuriya <[email protected]>
Thread::getId() is deprecated since Java 19, hence replaced Thread::getId() with Thread::threadId() in the repository as mentioned in #18205 Signed-off-by: hsanirudh <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
* Add Prudhvi Godithi (GH: prudhvigodithi) as a maintainer Signed-off-by: Craig Perkins <[email protected]> * Keep spaces Signed-off-by: Craig Perkins <[email protected]> * Fix spacing Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Bo Zhang <[email protected]>
…18697) * Fix: Include named queries from rescore contexts in matched_queries array - Modified QueryRescoreContext to store ParsedQuery instead of just Query - Updated QueryRescorerBuilder to use context.toQuery() for capturing named queries - Enhanced MatchedQueriesPhase to collect named queries from all rescore contexts - Added comprehensive tests for both unit and REST API scenarios - Resolves inconsistency with Elasticsearch behavior where rescore named queries were not surfaced - Cleaned up unnecessary comments for better code readability Signed-off-by: Girish Jeyakumar <[email protected]> * Address maintainer feedback: update RescoreContext interface design - Added parsedQuery() method to RescoreContext interface - Added getParsedQueries() method to RescoreContext interface - Updated QueryRescoreContext to override interface methods - Removed instanceof check in MatchedQueriesPhase by using interface method - Simplified assignment in QueryRescorerBuilder to one line Signed-off-by: Girish Jeyakumar <[email protected]> * Complete interface replacement: replace query() with parsedQuery() and getQueries() with getParsedQueries() - Removed query() method from QueryRescoreContext - Removed getQueries() method from RescoreContext interface - Updated all callers to use parsedQuery().query() instead of query() - Updated DfsPhase to use getParsedQueries() instead of getQueries() - Updated QueryRescorer to use parsedQuery().query() for rescoring and explanations - Updated QueryRescorerBuilderTests to use parsedQuery().query() - This addresses the maintainer's feedback for a cleaner interface design Signed-off-by: Girish Jeyakumar <[email protected]> * Finalize interface design and move changelog entry to Added section - Removed parsedQuery() method from RescoreContext base interface - Renamed getParsedQuery() to parsedQuery() in QueryRescoreContext for consistency - Updated all callers to use parsedQuery() method - Moved changelog entry to 'Added' section (more appropriate than 'Fixed') - Added proper imports for ParsedQuery to improve code readability - All tests pass and code formatting is correct Final interface design: - RescoreContext: only getParsedQueries() (returns List<ParsedQuery>) - QueryRescoreContext: parsedQuery() + getParsedQueries() override - MatchedQueriesPhase: uses getParsedQueries().forEach() for clean iteration This addresses all maintainer feedback from @mch2 and provides a clean, well-tested implementation that surfaces named queries from rescore contexts in the matched_queries array. Signed-off-by: Girish Jeyakumar <[email protected]> * Maintain backward compatibility for RescoreContext public API - Restore getQueries() method for backward compatibility - Add getParsedQueries() method for new functionality Signed-off-by: Girish Jeyakumar <[email protected]> * Fix mixed cluster test failure by updating skip version to 3.2.0 Signed-off-by: girish jeyakumar <[email protected]> --------- Signed-off-by: Girish Jeyakumar <[email protected]> Signed-off-by: girish jeyakumar <[email protected]> Signed-off-by: Marc Handalian <[email protected]> Co-authored-by: Girish Jeyakumar <[email protected]> Co-authored-by: Marc Handalian <[email protected]>
* Some explicit transient gRPC deps are not the expected version. grpc-netty-shaded:1.68.2 expects perfmark-api:0.27.0 guava:33.2.1-jre expects failureaccess:1.0.2 Signed-off-by: Finn Carroll <[email protected]> * Update license shas. Signed-off-by: Finn Carroll <[email protected]> * Changelog. Signed-off-by: Finn Carroll <[email protected]> * Rebase changelog. Signed-off-by: Finn Carroll <[email protected]> --------- Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]>
* Fix max_score is null when sorting on score firstly Signed-off-by: Binlong Gao <[email protected]> * modify changelog Signed-off-by: Binlong Gao <[email protected]> * Fix test failure Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
* Changes for the Upload Workflow for merged segments Signed-off-by: Aditi Goyal <[email protected]> * Addressed Todos Signed-off-by: Aditi Goyal <[email protected]> * Added Test Cases Signed-off-by: Aditi Goyal <[email protected]> * Removed the usage of Forbidden APIs Signed-off-by: Aditi Goyal <[email protected]> * Updated the code to include priority upload as paramter Signed-off-by: Aditi Goyal <[email protected]> * Updated the remote listener to use remote upploader interface Signed-off-by: Aditi Goyal <[email protected]> * Added JavaDocs across the changes Signed-off-by: Aditi Goyal <[email protected]> * Addressed spotless check Signed-off-by: Aditi Goyal <[email protected]> * Dummy commit(can be reverted) Signed-off-by: Aditi Goyal <[email protected]> * Revert "Dummy commit(can be reverted)" This reverts commit e542b99. Signed-off-by: Aditi Goyal <[email protected]> --------- Signed-off-by: Aditi Goyal <[email protected]> Co-authored-by: Aditi Goyal <[email protected]>
Signed-off-by: guojialiang <[email protected]>
* Code Improvement Signed-off-by: Prudhvi Godithi <[email protected]> * Code Improvement with a new method Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>
…ns/repository-hdfs (#18745) * Bump org.apache.commons:commons-lang3 in /plugins/repository-hdfs Bumps org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-version: 3.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ildSrc/src/testKit/thirdPartyAudit/sample_jars (#18744) * Bump org.apache.logging.log4j:log4j-core Bumps org.apache.logging.log4j:log4j-core from 2.25.0 to 2.25.1. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-core dependency-version: 2.25.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ns/repository-azure (#18742) * Bump com.azure:azure-storage-common in /plugins/repository-azure Bumps [com.azure:azure-storage-common](https://github.com/Azure/azure-sdk-for-java) from 12.29.0 to 12.29.1. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-storage-blob_12.29.0...azure-storage-blob_12.29.1) --- updated-dependencies: - dependency-name: com.azure:azure-storage-common dependency-version: 12.29.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <[email protected]>
…s/plugin-cli (#18743) * Bump com.google.jimfs:jimfs in /distribution/tools/plugin-cli Bumps [com.google.jimfs:jimfs](https://github.com/google/jimfs) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/google/jimfs/releases) - [Commits](google/jimfs@v1.3.0...v1.3.1) --- updated-dependencies: - dependency-name: com.google.jimfs:jimfs dependency-version: 1.3.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <[email protected]>
…8660) Signed-off-by: Shreyansh Ray <[email protected]>
The `upgrade-cli` tool is deprecated and no longer needed. - Removed: distribution/tools/upgrade-cli - Cleaned up: settings.gradle, distribution/build.gradle - Deleted: distribution/src/bin/opensearch-upgrade(.bat) Signed-off-by: BeomSeogKim <[email protected]>
Signed-off-by: Shahbaz Aamir <[email protected]>
…sterPlugin is loaded (#18479) These are the core changes to allow ClusterPlugins to manage cluster state on behalf of an OpenSearch node. If a "clusterless" ClusterPlugin is loaded, then the node will start up with dummy versions of Discovery and ClusterManagerService, and will load the minimum cluster state required for startup (essentially, the node needs to see itself). From there, the ClusterPlugin can interact with ClusterApplierService to apply some cluster state to the node. (The details of constructing/receiving that cluster state is up to the plugin.) --------- Signed-off-by: Michael Froh <[email protected]>
…emoval (#18661) Signed-off-by: Shreyansh Ray <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
…8746) * Bump com.google.jimfs:jimfs from 1.3.0 to 1.3.1 in /qa/evil-tests Bumps [com.google.jimfs:jimfs](https://github.com/google/jimfs) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/google/jimfs/releases) - [Commits](google/jimfs@v1.3.0...v1.3.1) --- updated-dependencies: - dependency-name: com.google.jimfs:jimfs dependency-version: 1.3.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> * Fix build failure Signed-off-by: Binlong Gao <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Binlong Gao <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Binlong Gao <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: cwperks <[email protected]>
* startree node,indices,shards stats Signed-off-by: Sandesh Kumar <[email protected]> * changing to builder pattern Signed-off-by: Sandesh Kumar <[email protected]> * add query current, fix version Signed-off-by: Sandesh Kumar <[email protected]> * fix version Signed-off-by: Sandesh Kumar <[email protected]> * add integ test Signed-off-by: Sandesh Kumar <[email protected]> * typo Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]>
…ository-azure (#18759) * Bump com.nimbusds:nimbus-jose-jwt in /plugins/repository-azure Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 10.2 to 10.3.1. - [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.3.1..10.2) --- updated-dependencies: - dependency-name: com.nimbusds:nimbus-jose-jwt dependency-version: 10.3.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> * Fix build failure Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Binlong Gao <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Binlong Gao <[email protected]>
This class was recently changed to use `SecureRandom.getInstanceStrong()` instead of `new SecureRandom()`. This results in a blocking call on certain systems if the entropy is exhausted. This commit reverts back to the previous implementation in the non-FIPS case to avoid problems with blocking. Signed-off-by: Andrew Ross <[email protected]>
* port over plugin extension, double check with knn tests Signed-off-by: TJ Neuenfeldt <[email protected]> * changelog, added tests, changed to contexualpb for context Signed-off-by: TJ Neuenfeldt <[email protected]> * spotless Signed-off-by: TJ Neuenfeldt <[email protected]> * renamed, made extension point a function Signed-off-by: TJ Neuenfeldt <[email protected]> * changelog, default ctors Signed-off-by: TJ Neuenfeldt <[email protected]> * added getter, changed to findProfileBreakdown Signed-off-by: TJ Neuenfeldt <[email protected]> * changelog and abstractpb Signed-off-by: TJ Neuenfeldt <[email protected]> * trigger Signed-off-by: TJ Neuenfeldt <[email protected]> * revert breaking change Signed-off-by: TJ Neuenfeldt <[email protected]> * trigger Signed-off-by: TJ Neuenfeldt <[email protected]> * trigger build Signed-off-by: TJ Neuenfeldt <[email protected]> * search module nit fix Signed-off-by: TJ Neuenfeldt <[email protected]> * spotless Signed-off-by: TJ Neuenfeldt <[email protected]> --------- Signed-off-by: TJ Neuenfeldt <[email protected]> Signed-off-by: TJ Neuenfeldt <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.