Skip to content

fix: /member/me with onboarding user return 401 Unauthorized #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tape4 merged 1 commit into from
May 16, 2025
Merged

fix: /member/me with onboarding user return 401 Unauthorized #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...rg/fontory/fontorybe/authentication/domain/exception/AuthenticationRequiredException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package org.fontory.fontorybe.authentication.domain.exception;

import org.fontory.fontorybe.common.domain.SkipDiscordNotification;

@SkipDiscordNotification
public class AuthenticationRequiredException extends RuntimeException {
public AuthenticationRequiredException() {
super("Authentication required");
}
}
7 changes: 7 additions & 0 deletions src/main/java/org/fontory/fontorybe/common/adapter/inbound/GlobalExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import io.jsonwebtoken.JwtException;
import io.jsonwebtoken.MalformedJwtException;
import lombok.RequiredArgsConstructor;
import org.fontory.fontorybe.authentication.domain.exception.AuthenticationRequiredException;
import org.fontory.fontorybe.authentication.domain.exception.InvalidRefreshTokenException;
import org.fontory.fontorybe.authentication.domain.exception.TokenNotFoundException;
import org.fontory.fontorybe.bookmark.domain.exception.BookmarkAlreadyException;
Expand Down Expand Up @@ -169,4 +170,10 @@ public BaseErrorResponse fileNotFoundException(FileNotFoundException e) {
public BaseErrorResponse containsBadWordException(Exception e) {
return new BaseErrorResponse(e.getMessage());
}

@ResponseStatus(HttpStatus.UNAUTHORIZED)
@ExceptionHandler(AuthenticationRequiredException.class)
public BaseErrorResponse authenticationRequiredException(AuthenticationRequiredException e) {
return new BaseErrorResponse(e.getMessage());
}
}
5 changes: 5 additions & 0 deletions src/main/java/org/fontory/fontorybe/member/controller/ProfileController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import org.fontory.fontorybe.authentication.adapter.inbound.annotation.Login;
import org.fontory.fontorybe.authentication.application.AuthService;
import org.fontory.fontorybe.authentication.domain.UserPrincipal;
import org.fontory.fontorybe.authentication.domain.exception.AuthenticationRequiredException;
import org.fontory.fontorybe.file.application.port.CloudStorageService;
import org.fontory.fontorybe.file.application.port.FileService;
import org.fontory.fontorybe.file.domain.FileUploadResult;
Expand All @@ -20,6 +21,7 @@
import org.fontory.fontorybe.member.controller.port.MemberLookupService;
import org.fontory.fontorybe.member.controller.port.MemberUpdateService;
import org.fontory.fontorybe.member.domain.Member;
import org.fontory.fontorybe.member.infrastructure.entity.MemberStatus;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.*;
Expand Down Expand Up @@ -54,6 +56,9 @@ public ResponseEntity<MyProfileResponse> getMyProfile(
log.info("Request received: getMyInfo member ID: {}", requestMemberId);

Member lookupMember = memberLookupService.getOrThrowById(requestMemberId);
if (lookupMember.getStatus().equals(MemberStatus.ONBOARDING)) {
throw new AuthenticationRequiredException();
}
String fileUrl = cloudStorageService.getProfileImageUrl(lookupMember.getProfileImageKey());
log.info("ProfileImageUrl generated : {}", fileUrl);

Expand Down
Loading