feat: components update #9645
Open
feat: components update #9645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
force-pushed
the
linking-components
branch
from
664b7d3 to
6fb7fd8
Compare
Component dependencies should link to components in the workspace
zkochan
force-pushed
the
linking-components
branch
from
6fb7fd8 to
20ad2c4
Compare
|
I had to add repeat install in one scenario: when a new dependency installed that has a component from the workspace in dependencies. This was the only way of doing it because we don't have the dependency graph of the new dependency before resolution is done by the first install. In most cases this repeat install will be fast because the newly installed dependency will be "latest" unless the user specifically installs an older version (which might need to be an error? in which case no need in a second install). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component dependencies should link to components in the workspace
Proposed Changes