Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ConverterSelector strategy #42

Draft
wants to merge 2 commits into
base: rebuild-config
Choose a base branch
from
Draft

New ConverterSelector strategy #42

wants to merge 2 commits into from

Conversation

mike4git
Copy link
Collaborator

Find the right Converter not only a string.

The idea of this PR is to change the implementation of ConverterSelector and return Converter instead of mapping types (e.g. string or array_keys)

jdreesen and others added 2 commits February 6, 2023 23:38
@jdreesen
Deprecate "neusta_converter.converter" config and rebuild it as "neus…
d5831fb 
…ta_converter.converters"
@mike4git
add new ConverterSelector strategy:
66f8433 
Find the right Converter not only a string.
@mike4git
Copy link
Collaborator Author

ATM, there is a neusta configuration missing for the selector.
May be it is not necessary because the ConverterSelector could be defined in several, different, not-normalizable ways so we just assign the Symfony id to the selector section.
What do you think about?!

@jdreesen jdreesen added the BC-BREAK Breaks backwards compatibility label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC-BREAK Breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike4git @jdreesen