Fix manifest for edge

techfromsage · Mar 7, 2018 · 2108e9e · 2108e9e
1 parent 7eaaf53
commit 2108e9e
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -63,7 +63,14 @@ module.exports = function(grunt) {
     if (grunt.option('identifier')) {
       manifest.applications = { 'gecko': { 'id': grunt.option('identifier') } };
     }
-    if (browser !== 'msedge') {
+    if (browser === 'msedge') {
+      manifest.icons = [
+        {"sizes":"16x16", "src": "images/icon16.png"},
+        {"sizes": "30x30", "src": "images/icon30.png"},
+        {"sizes": "50x50", "src": "images/icon50.png"},
+        {"sizes":"120x120", "src": "images/icon120.png"}
+      ];
+    } else {
       delete(manifest['-ms-preload']);
     }
     grunt.file.write(grunt.config('distdir') + '/manifest.json', JSON.stringify(manifest, null, 2));

diff --git a/_locales/cy/messages.json b/_locales/cy/messages.json
@@ -3,6 +3,10 @@
         "message": "Talis Aspire Rhestrau Darllen Offeryn Nod Tudalen",
         "description": "Extension name"
     },
+    "description": {
+        "message": "Talis Aspire Rhestrau Darllen Offeryn Nod Tudalen",
+        "description": "Extension description"
+    },    
     "browserActionTitle": {
         "message": "Ychwanegu Llyfrnod at Rhestr Ddarllen",
         "description": "Message when hovering over extension button"

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
@@ -3,6 +3,10 @@
         "message": "Talis Aspire Reading Lists Bookmarking",
         "description": "Extension name"
     },
+    "description": {
+        "message": "Talis Aspire Reading Lists Bookmarking",
+        "description": "Extension description"
+    },    
     "browserActionTitle": {
         "message": "Bookmark to Talis Aspire Reading Lists",
         "description": "Message when hovering over extension button"

diff --git a/manifest.json b/manifest.json
@@ -1,6 +1,7 @@
 {
     "name": "__MSG_extensionName__",
     "author": "Talis Education Limited",
+    "description":"__MSG_description__",
     "version": "__VERSION__",
     "icons":  { 
         "16": "images/icon16.png",