Skip to content

Commit

Permalink
Merge branch 'remove-bower' into better-permissions
Browse files Browse the repository at this point in the history
  • Loading branch information
rsinger committed Jun 13, 2019
2 parents fc769af + 345964e commit f094704
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 41 deletions.
22 changes: 12 additions & 10 deletions Gruntfile.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,21 @@
module.exports = function(grunt) {

// Project configuration.
grunt.initConfig({
pkg: grunt.file.readJSON('package.json'),
distdir: './dist',
copy: {
bower: {
dependencies: {
files: [
{
expand: true,
cwd: './',
cwd: './node_modules',
src: [
'bower_components/bootstrap/dist/js/bootstrap.min.js',
'bower_components/bootstrap/dist/css/bootstrap.min.css',
'bower_components/jquery/dist/jquery.min.js'
'bootstrap/dist/js/bootstrap.min.js',
'bootstrap/dist/css/bootstrap.min.css',
'jquery/dist/jquery.min.js'
],
dest: 'dist'
}
dest: 'dist/dependencies'
},
]
},
common: {
Expand Down Expand Up @@ -50,6 +49,9 @@ module.exports = function(grunt) {
manifest.version = grunt.config('pkg.version');
if (grunt.option('identifier')) {
manifest.applications = { 'gecko': { 'id': grunt.option('identifier') } };
delete manifest.options_page;
delete manifest.options_ui.chrome_style;
manifest.options_ui.browser_style = true;
}
if (dist === 'manifold') {
// manifoldjs requires a completely different icons schema for packaging edge extensions
Expand All @@ -70,12 +72,12 @@ module.exports = function(grunt) {
grunt.registerTask(
'dist-common',
'Create distribution for Web Extension browsers',
['create-dist-dir', 'write-manifest:common', 'copy:bower', 'copy:common']
['create-dist-dir', 'write-manifest:common', 'copy:dependencies', 'copy:common']
);
grunt.registerTask(
'dist-manifold',
'Create distribution for Web Extension browsers',
['create-dist-dir', 'write-manifest:manifold', 'copy:bower', 'copy:common']
['create-dist-dir', 'write-manifest:manifold', 'copy:dependencies', 'copy:common']
);
grunt.registerTask('default', ['dist-common']);
};
24 changes: 0 additions & 24 deletions bower.json

This file was deleted.

10 changes: 5 additions & 5 deletions options.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
<head>
<meta name="viewport" content="width=device-width, initial-scale=1">
<title data-message="optionsTitle">Talis Aspire Reading Lists Bookmarking Options</title>
<script src="/bower_components/jquery/dist/jquery.min.js"></script>
<link rel="stylesheet" href="/bower_components/bootstrap/dist/css/bootstrap.min.css" />
<script src="/dependencies/jquery/dist/jquery.min.js"></script>
<link rel="stylesheet" href="/dependencies/bootstrap/dist/css/bootstrap.min.css" />
<link rel="stylesheet" href="css/options.css" />
<script src="/bower_components/bootstrap/dist/js/bootstrap.min.js"></script>
<script src="/dependencies/bootstrap/dist/js/bootstrap.min.js"></script>
<script src="js/allTenants.js"></script>
<script src="js/tenants.js"></script>
<script src="js/options.js"></script>
Expand Down Expand Up @@ -35,8 +35,8 @@
<div class="col-xs-8">
<input type="text" id="tenantCode" />
</div>
</div>
</div>

</div>
</body>
</html>
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"grunt": "^1.0.1",
"grunt-contrib-copy": "^1.0.0"
},
"scripts": {
"postinstall": "./node_modules/.bin/bower install"
"dependencies": {
"bootstrap": "^3.3.6",
"jquery": "^3.3.1"
}
}

0 comments on commit f094704

Please sign in to comment.