Skip to content

Fix some issues found by lgtm.com #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some issues found by lgtm.com #64

wants to merge 1 commit into from

Conversation

misery
Copy link

@misery misery commented Jul 31, 2019

  • This import of module shutil is redundant, as it was previously imported on line 35.
  • Testing for None should use the 'is' operator.
  • The value assigned to local variable 'hno' is never used.

@misery
Fix some issues found by lgtm.com
942aab5 
* This import of module shutil is redundant, as it was previously imported on line 35.
* Testing for None should use the 'is' operator.
* The value assigned to local variable 'hno' is never used.
This was referenced Sep 27, 2019
Closed
Closed
Merged
@techtonik
Copy link
Owner

lgtm.com is right about shutil, but I've heard from Fedora users that shutil has some permission problems. I need to ask them for testing as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misery @techtonik