Skip to content

⚡ Bolt: avoid libm::sqrt in Sparse Attention Graph spatial scans#122

Open
teerthsharma wants to merge 1 commit into
masterfrom
bolt-optimize-is-neighbor-4446327687940072145
Open

⚡ Bolt: avoid libm::sqrt in Sparse Attention Graph spatial scans#122
teerthsharma wants to merge 1 commit into
masterfrom
bolt-optimize-is-neighbor-4446327687940072145

Conversation

@teerthsharma

Copy link
Copy Markdown
Owner

💡 What: Replaced the full distance() < epsilon calculation in ManifoldPoint::is_neighbor with an inline loop that computes squared distances and exits early if the accumulated sum exceeds epsilon^2.
🎯 Why: The is_neighbor function is a critical bottleneck called inside the inner O(N) loop of SparseAttentionGraph::add_point. Computing the libm::sqrt and evaluating all dimensions for distant points introduces severe computational overhead.
📊 Impact: Significantly accelerates point additions in the topological pipeline by avoiding sqrt and short-circuiting distance evaluations.
🔬 Measurement: Verify by running cargo test -p aether-core and observing no regressions in manifold::tests::test_sparse_attention_neighbor and test_point_distance. Run micro-benchmarks on add_point to measure latency improvements.


PR created automatically by Jules for task 4446327687940072145 started by @teerthsharma

Replaced the `distance() < epsilon` check in `is_neighbor` with an inline loop using squared distances and an early exit. This eliminates the `libm::sqrt` overhead inside the critical path of `SparseAttentionGraph::add_point`, which performs O(N) neighbor checks for every new point on the manifold. NaN thresholds and values are safely handled.

Co-authored-by: teerthsharma <78080953+teerthsharma@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant