Skip to content

⚡ Bolt: Optimize Tensor initialization and operations#128

Open
teerthsharma wants to merge 1 commit into
masterfrom
bolt/tensor-optimizations-5113574221031741293
Open

⚡ Bolt: Optimize Tensor initialization and operations#128
teerthsharma wants to merge 1 commit into
masterfrom
bolt/tensor-optimizations-5113574221031741293

Conversation

@teerthsharma

Copy link
Copy Markdown
Owner

💡 What: Replaced manual index loops and Vec push operations with single-pass iterator chains in tensor.rs (add, mul, scale, sub, map) and linalg.rs (LossConfig::derivative). The result is now directly constructed via Tensor::from_vec() instead of Tensor::new().
🎯 Why: Tensor::new() implicitly invokes .to_vec() on the input slice, causing a double heap allocation. Manual for loops with .push() introduce bounds checking and loop overhead inside highly repetitive ML routines.
📊 Impact: Completely eliminates an extra $O(N)$ heap allocation inside scalar reductions and arithmetic ops, while removing bounds checks by leveraging standard iterators.
🔬 Measurement: Run the test suite (cargo test -p aether-core --offline) and look for correct outputs. Benchmarks on Tensor::add or mse derivatives will show reduced memory overhead and increased throughput.


PR created automatically by Jules for task 5113574221031741293 started by @teerthsharma

Replaced manual index loops and Vec pushing with single-pass iterator chains and `Tensor::from_vec()` in `tensor.rs` and `linalg.rs`. This avoids redundant slice heap allocations and bypasses bounds checking.

Co-authored-by: teerthsharma <78080953+teerthsharma@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant