⚡ Bolt: Optimize backpropagation to use zero-copy ownership transfer#141
⚡ Bolt: Optimize backpropagation to use zero-copy ownership transfer#141teerthsharma wants to merge 1 commit into
Conversation
Modified `DenseLayer::backward` to use `Option::take()` instead of `.clone()` for cached tensors, avoiding heap allocations of metadata during the backward pass. Modified `MLP::forward` to avoid cloning the input tensor on the first layer. Co-authored-by: teerthsharma <78080953+teerthsharma@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced
.as_ref().unwrap().clone()with.take().unwrap()inDenseLayer::backwardforlast_zandlast_input. Also refactoredMLP::forwardto borrow and pass the initial input directly to the first layer, eliminating an unnecessary clone.🎯 Why:
Tensorinstances inaether-coreuseRc<RefCell<Vec<f64>>>for data, but cloning them still requires a heap allocation forshapeandstridesvectors. During backpropagation, these cached tensors are consumed entirely, so moving them transfers ownership without copying metadata.📊 Impact: Eliminates multiple redundant metadata heap allocations per forward/backward pass during training loops.
🔬 Measurement: Verify changes in
crates/aether-core/src/ml/neural.rs. The code is covered bycargo test -p aether-core --offline -- ml::neuralwhich runs cleanly.PR created automatically by Jules for task 5293134432065391883 started by @teerthsharma