[IMP] impressions: Remove dependancy on encounters #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etobella
force-pushed
the
16.0-fix-impression
branch
2 times, most recently
from
4381734 to
ee3d200
Compare
etobella
force-pushed
the
16.0-fix-impression
branch
from
ee3d200 to
67e35ed
Compare
luisDIXMIT
reviewed
Jan 22, 2025
| @@ -36,21 +36,13 @@ | |||
| <field name="name">Gynecology</field> | |||
| <field name="description">Gynecology</field> | |||
| </record> | |||
| <record id="encounter_01_patient_01" model="medical.encounter"> | |||
There was a problem hiding this comment.
Esto no lo añades en medical_clinical_impression_encounter
| <record id="impression_01_patient_01" model="medical.clinical.impression"> | ||
| <field name="fhir_state">completed</field> | ||
| <field | ||
| name="specialty_id" | ||
| ref="medical_clinical_impression.specialty_gynecology" | ||
| /> | ||
| <field name="patient_id" ref="medical_base.patient_01" /> | ||
| <field |
There was a problem hiding this comment.
Esto creo que también se debería añadir en medical_clinical_impression_encounter
There was a problem hiding this comment.
Son datos de DEmo y no son muy relevantes
luisDIXMIT
reviewed
Jan 22, 2025
| # FHIR: encounter | ||
|
|
||
| patient_id = fields.Many2one( | ||
| related="encounter_id.patient_id", readonly=True, states={} |
There was a problem hiding this comment.
De esta forma, al instalar este módulo se sobreescribe el comportamiento del campo patient_id y ya no puede ser elegido será establecido por el patient relacionado en el campo encounter_id. ¿Es la intención la de tener diferente funcionamiento?
etobella
force-pushed
the
16.0-fix-impression
branch
from
9aac4d8 to
3d0acd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.