Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also display swapped objkts in collection #388

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Conversation

Zir0h
Copy link
Contributor

@Zir0h Zir0h commented Feb 23, 2024

Maybe fix for #387 ?

Copy link

github-actions bot commented Feb 23, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-25 19:14 UTC

@Zir0h
Copy link
Contributor Author

Zir0h commented Feb 23, 2024

Probably already fixed in develop? 11ffbbc

@floydwilde
Copy link

I'm not sure there is any reason to be filtering on if an item is for sale or not on that page. We only want to filter on items that the user owns that they have not created. Whether it's for sale or not doesn't matter, I've proposed to remove those unneeded filters in: #389

Copy link
Member

@melMass melMass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melMass melMass merged commit 0efa21d into main Feb 25, 2024
3 checks passed
@melMass melMass deleted the feat-show-swapped-tokens branch February 25, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants