Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] add hpa under options and support pod template labels and annotations #1942

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

jkandasa
Copy link
Member

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

- Added support to update/create HorizontalPodAutoscaler via `options`.
- Added support for adding labels and annotations on Deployments and StatefulSets podTemplate via `options`.

@jkandasa jkandasa added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 19, 2024
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 19, 2024
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2024
@jkandasa jkandasa marked this pull request as draft January 19, 2024 06:42
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2024
@jkandasa jkandasa force-pushed the hpa_as_options branch 2 times, most recently from 4f78d17 to 0fea34f Compare January 19, 2024 07:08
@tektoncd tektoncd deleted a comment from tekton-robot Jan 19, 2024
@tektoncd tektoncd deleted a comment from tekton-robot Jan 19, 2024
@jkandasa jkandasa marked this pull request as ready for review January 19, 2024 07:13
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2024
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformer_additional_options.go 90.1% 88.0% -2.1

@tektoncd tektoncd deleted a comment from tekton-robot Jan 22, 2024
@jkandasa jkandasa requested a review from vdemeester January 22, 2024 03:19
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformer_additional_options.go 90.1% 88.0% -2.1

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@tekton-robot tekton-robot merged commit 8a69188 into tektoncd:main Jan 23, 2024
8 checks passed
@jkandasa jkandasa deleted the hpa_as_options branch January 23, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend custom annotations support in TektonConfig
4 participants