Ensure the configured TargetNamespace overrides the default namespace in the Dashboard's container args

[aThorp96]

Changes

Fixes #2438

• Remove results specific details from the common transformer code
• Ensure the configured TargetNamespace overrides the default namespace in the Dashboard's container args

I've tested this locally and confirmed that the Operator created a deployment for the Dashboard with the correct namespace override per the workflow described in #2438 , however it would be good to have someone test and verify the effect on their end as well

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Run make test lint before submitting a PR
• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

When `defaultTargetNamespace` is specified in the Tekton Config, the value will now override the Dashboard's container args `--pipelines-namespace` and `--triggers-namespace`.

[tekton-robot]

Hi @aThorp96. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pratap0007]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektondashboard/transform.go	85.7%	86.7%	1.0

[aThorp96]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektondashboard/transform.go	85.7%	86.7%	1.0

[pratap0007]

LGTM

[PuneetPunamiya]

What if a new deployment is added to results component 🤔

[aThorp96]

In the previous implementation the new deployment name would need to have been added to pkg/reconciler/common/transformers.go's list of results deployments and to the check in ReplaceNamespaceInDeploymentEnv and ReplaceNamespaceInDeploymentArgs.

In this new implementation, the new deployment name would be added here and the the array resultDeploymentNames on line 64

[PuneetPunamiya]

Yeah make sense

[jkhelil]

/approve

[PuneetPunamiya]

/lgtm

[aThorp96]

@PuneetPunamiya for some reason prow didn't seem to respond to your /lgtm or @jkhelil's /approve 🤔

Is anything else required here or was this just a blip in prow?

[PuneetPunamiya]

/approve
/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil, PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [PuneetPunamiya,jkhelil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment