fix(security): marketplace token scoping, WebUI/setup hardening, atom…#1
Merged
Merged
Conversation
…ic PIN lockout - Market.app: remove global API token; pass token via ToolContext and createMarketAppAdapter(token) to prevent cross-user leakage under concurrency. - WebUI: drop ?token= auth for /api/*; avoid logging full exchange URL with secret. - Setup: require x-teleclaw-launch-nonce for /api/setup/launch; web fetches nonce first. - Wallet PIN: atomic failed_attempts increment + lockout via single UPDATE RETURNING. - Remove unsafe unused MemoryDatabase.asyncTransaction (await breaks transaction). - pretest: build SDK so @teleclaw-agent/sdk resolves for npm test. - Tests: marketapp token scope, security PIN flow. Made-with: Cursor
gioooton
approved these changes
Mar 25, 2026
gioooton
left a comment
gioooton
left a comment
Collaborator
There was a problem hiding this comment.
Solid security work. Token scoping fixes a real concurrency bug, atomic PIN lockout eliminates the race condition, WebUI hardening removes token-in-URL leaks, and the setup nonce is a nice touch. Tests included. Clean and well-scoped. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ic PIN lockout
Made-with: Cursor
Description
Brief description of the changes and their motivation.
Type of Change
Checklist
devbranch (notmain)npm run typecheckpassesnpm run lintpassesnpm testpassesRelated Issues
Closes #(issue number)