-
Notifications
You must be signed in to change notification settings - Fork 91
Prepend NGSI-v1 to the v1 tests, NGSI-v2 to the v2 tests #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Simple Grep rename of the descriptions of the NGSI v2 tests, to distinguish them from the NGSI-LD test suite
Simple Grep rename of the descriptions of the NGSI v2 tests, to distinguish them from the NGSI-LD test suite
}; | ||
|
||
describe('Expression-based transformations plugin', function() { | ||
describe('NGSI-v2 - Expression-based transformations plugin', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure but many of these tests are "parallel" to existing ones in NGSIv1 (maybe @dcalvoalonso could confirm, as he did great part of the implementation).
In that case, maybe it's a good idea to add a 'NGSI-v1 -
prefix also in those ones, for the sake of completeness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 718ca29
This case is different from #841 (comment) in the sense in this case the test files are not new but pre-existing. In my opinion, the decision should depend on the impact on other people's ongoing works. In other words, are the test files you plan to change already being changed in some of the ongoing PRs we have in the repository (apart from yours and mine)? |
Current list of amended tests in outstanding PRs.
|
Updated the NGSI-v1 test files which have equivalent NSGI-v2 test to distinguish between v1, v2 and LD
Since the update now touches both NGSI-v1 and NGSI-v2 the answer would be YES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ngsi-ld-measure Applying telefonicaid#839 and telefonicaid#840 to reduce diff with master
Simple Grep rename of the descriptions of the NGSI v2 tests, to distinguish them from the NGSI-LD test suite
Also updated the NGSI-v1 test files which have equivalent tests to distinguish between v1, v2 and LD