Skip to content

Add common NGSI-LD constants #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Add common NGSI-LD constants #897

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e487d17
Add common NGSI-LD constants
jason-fox Sep 7, 2020
9d65c09
Remove unused constants
jason-fox Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
* Modified by: Daniel Calvo - ATOS Research & Innovation
*/

const LOCATION_TYPE = 'geo:point';
const LOCATION_DEFAULT = '0, 0';
const DATETIME_TYPE = 'DateTime';
const DATETIME_DEFAULT = '1970-01-01T00:00:00.000Z';
const ATTRIBUTE_DEFAULT = ' ';

Expand All @@ -36,10 +34,18 @@ const ATTRIBUTE_DEFAULT = ' ';
* @return {String} A default value to use in the entity
*/
function getInitialValueForType(type) {
switch (type) {
case LOCATION_TYPE:
switch (type.toLowerCase()) {
case 'geoproperty':
return LOCATION_DEFAULT;
case DATETIME_TYPE:
Comment on lines -40 to -42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other usage of LOCATION_TYPE and DATETIME_TYPE (removed in this PR) appart of the ones in this point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like it, so those statements are now redundant and can be removed. Fixed 9d65c09

case 'point':
return LOCATION_DEFAULT;
case 'geo:point':
return LOCATION_DEFAULT;
case 'datetime':
return DATETIME_DEFAULT;
case 'date':
return DATETIME_DEFAULT;
case 'time':
return DATETIME_DEFAULT;
default:
return ATTRIBUTE_DEFAULT;
Expand Down