chore: add coffee-warehouse example #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdravkov
approved these changes
Nov 5, 2021
| methods: { | ||
| setSelectedState(id, theme) { | ||
| if (id === 1) { | ||
| this.teamClass = theme + " k-state-selected"; |
There was a problem hiding this comment.
such code is quite often a 'code smell' - one thing that comes to my mind is to check in the computed property what is the selectedMenuItem and add the selected class depending on it there.
There was a problem hiding this comment.
In commit 1435fc6 the logic is simplified to call the updateSelectedMenuItem method when two watchers are changed. Using computed properties throws an unusual error' Write operation failed: computed property is read only.' I think it appears because the values of these computed properties are used in the items computed property.
coffee-warehouse/src/components/GridComponents/IsOnlineComponent.vue
Outdated
Show resolved
Hide resolved
coffee-warehouse/src/components/GridComponents/BudgetComponent.vue
Outdated
Show resolved
Hide resolved
zdravkov
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.