Fix according review#2650
Closed
EvgeniiMekhanik wants to merge 4 commits into
Closed
Conversation
- Rename `client_mem_cache` to `tfw_client_mem_cache`. - Change `in_free_list` from struct list_head to pointer to save 8 bytes. - Implement 1GB mem limit by default. - Remove zeroing `skb->dev` from `ss_skb_init_for_xmit`. We already zero `skb->dev` at the beginning of processing skb and we don't need to do it at the end, because we don't use it.
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/fix-1715
branch
from
3d3b1b7 to
546a3b5
Compare
Add extra sanity checks: Warn in `cli_mem_release` if client memory is not zero at release time. Warn in `ss_skb_dflt_destructor` if skb memory counter is not fully decremented. These checks help detect memory accounting leaks earlier.
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/fix-1715
branch
from
5bd28a5 to
3e1125c
Compare
- Add comments for new implemented BUG_ONs - Remove BUG_ON from `tfw_h2_stream_send_postponed`. There is a possible case when conn->write_queue is not empty. - Remove http2 `ctx` from tfw_h2_entail_stream_skb` arguments.
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/fix-1715
branch
from
3e1125c to
54c2d3d
Compare
Contributor
Author
|
Create new branch with the same commits #2651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client_mem_cachetotfw_client_mem_cache.in_free_listfrom struct list_head to pointer to save 8 bytes.