Skip to content

Make the Event History code walkthrough zoomable, keep highlighted lines in view - #5085

Merged
Duncanma merged 2 commits into
mainfrom
event-history-walkthrough-zoom
Aug 11, 2026
Merged

Make the Event History code walkthrough zoomable, keep highlighted lines in view#5085
Duncanma merged 2 commits into
mainfrom
event-history-walkthrough-zoom

Conversation

@Duncanma

@Duncanma Duncanma commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a click-to-expand overlay to WorkflowWalkthrough (the interactive demo used by all four Event History walkthroughs, across every SDK language page). Unlike the site's existing image/Mermaid zoom, the expanded view stays fully interactive — same live component, not a static snapshot — so the step controls and keyboard navigation keep working while zoomed.

Also fixes two related issues found while building this:

  • The code panel used to clip long lines instead of letting you scroll to see the rest.
  • The highlighted line(s) for a step could end up outside the scrolled viewport with no indication; now they scroll into view automatically, in both the inline and zoomed views.

Notes to reviewers

Best tested by opening one of the Event History pages (e.g. /encyclopedia/event-history/event-history-java) and:

  • Clicking the expand icon on any of the four demos, confirming the step controls, keyboard arrows, and close (button/Escape/backdrop click) all work without closing on interactions inside the card.
  • Stepping through a long walkthrough (e.g. "History Replay") after manually scrolling the code panel, to see it re-center on the newly highlighted line.

┆Attachments: EDU-6931 Make the Event History code walkthrough zoomable, keep highlighted lines in view

…nes in view

Adds a click-to-expand overlay to WorkflowWalkthrough (used by all four
Event History demos across every SDK language page), matching the
site's existing image/Mermaid zoom pattern but keeping the walkthrough
fully interactive while zoomed instead of showing a static snapshot.

Also:
- Fixes the code panel clipping long lines instead of letting them
  scroll horizontally.
- Scrolls the highlighted line(s) into view automatically when the
  step changes, in both the inline and zoomed views.
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview Aug 11, 2026 4:18pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

This PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here.

@Duncanma
Duncanma marked this pull request as ready for review August 11, 2026 16:26
@Duncanma
Duncanma requested a review from a team as a code owner August 11, 2026 16:26
@Duncanma

Copy link
Copy Markdown
Contributor Author

@Duncanma
Duncanma merged commit 07c6a79 into main Aug 11, 2026
13 checks passed
@Duncanma
Duncanma deleted the event-history-walkthrough-zoom branch August 11, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants