Skip to content

Consolidate the AI review rubric into AGENTS.md - #5158

Merged
lennessyy merged 6 commits into
mainfrom
add-ai-review-rules
Aug 21, 2026
Merged

Consolidate the AI review rubric into AGENTS.md#5158
lennessyy merged 6 commits into
mainfrom
add-ai-review-rules

Conversation

@lennessyy

Copy link
Copy Markdown
Contributor

What

Scopes the automated review guidance to the three things a lint rule cannot check: collateral changes, structural fit, and text tone. Drops the terminology, redirect, sidebar, link, and Mermaid checks that Vale and CI already run.

Moves the rubric into AGENTS.md and removes .github/skills/code-review/SKILL.md. Copilot loads a skill only when its description matches, and Codex does not read .github/skills, so AGENTS.md is the only file every reviewer reads.

Scope the automated review to collateral changes, structural fit, and text
tone, and drop the checks that Vale and CI already cover.

Removes .github/skills/code-review/SKILL.md. Copilot reads a skill only when
its description matches, and Codex does not read .github/skills at all, so
AGENTS.md is the only file every reviewer reads.
Copilot AI balanced review requested due to automatic review settings August 21, 2026 17:44
@lennessyy
lennessyy requested a review from a team as a code owner August 21, 2026 17:44
@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview Aug 21, 2026 8:41pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

This PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Consolidates automated documentation-review guidance in the repository-wide AGENTS.md and removes the redundant Copilot-specific skill.

Changes:

  • Focuses reviews on collateral changes, structural fit, and text tone.
  • Documents checks handled by CI or Vale as out of scope.
  • Removes the superseded code-review skill.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
AGENTS.md Adds the consolidated review rubric.
.github/skills/code-review/SKILL.md Removes duplicate review guidance.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lennessyy

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@lennessyy

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: bd1b754a79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lennessyy
lennessyy enabled auto-merge (squash) August 21, 2026 20:39
@lennessyy
lennessyy merged commit 115beef into main Aug 21, 2026
10 checks passed
@lennessyy
lennessyy deleted the add-ai-review-rules branch August 21, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants