Skip to content

fix(components): changed PatternCards to use <Link> instead of <a> #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flippedcoder merged 3 commits into from
Aug 24, 2026
+13 −10
Merged

fix(components): changed PatternCards to use <Link> instead of <a> #5161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
843787a
fix(components): changed PatternCards to use <Link> instead of <a>
flippedcoder Aug 21, 2026
5a120c5
fix(components): replaced <a> with <Link> in other components
flippedcoder Aug 21, 2026
5a0de4a
Merge branch 'main' into mm/use-link
flippedcoder Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/PatternCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';
import Link from '@docusaurus/Link';
import useBaseUrl from '@docusaurus/useBaseUrl';

type PatternCardItem = {
Expand Down Expand Up @@ -26,9 +27,9 @@ export default function PatternCards({ items, className }: PatternCardsProps) {
return (
<div className={className ? `pattern-grid ${className}` : 'pattern-grid'}>
{items.map((item) => (
<a
<Link
key={item.href}
href={item.href}
to={item.href}
className="pattern-card"
{...(item.external ? { target: '_blank', rel: 'noopener noreferrer' } : {})}
>
Expand All @@ -43,7 +44,7 @@ export default function PatternCards({ items, className }: PatternCardsProps) {
)}
<p>{item.description}</p>
</div>
</a>
</Link>
))}
</div>
);
Expand Down
5 changes: 3 additions & 2 deletions src/components/Quickstart/Cards/QuickstartCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';
import Link from '@docusaurus/Link';
import SdkSvg from '../../elements/SdkSvgs/SdkSvg';
import { SDKS } from '../../../constants/sdks';
import styles from './QuickstartCards.module.css';
Expand All @@ -25,7 +26,7 @@ export default function QuickstartCards({ items, className }: QuickstartCardsPro
{items.map((item) => {
const sdk = SDK_BY_LABEL.get(item.title);
return (
<a key={item.href} className={styles.card} href={item.href}>
<Link key={item.href} className={styles.card} to={item.href}>
<div className={styles.cardHeader}>
{sdk && (
<span className={styles.iconWrapper}>
Expand All @@ -35,7 +36,7 @@ export default function QuickstartCards({ items, className }: QuickstartCardsPro
<h3 className={styles.cardTitle}>{item.title}</h3>
</div>
<p className={styles.cardDesc}>{item.description}</p>
</a>
</Link>
);
})}
</div>
Expand Down
11 changes: 6 additions & 5 deletions src/components/elements/Sdk/SdkOverviewCards/SdkOverviewCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// labels, or API reference links there, update that handler too. See
// MARKDOWN_PIPELINE.md.
import React from 'react';
import Link from '@docusaurus/Link';
import SdkSvg from '../../SdkSvgs/SdkSvg';
import { SDKS } from '../../../../constants/sdks';
import sdkVersions from '../../../../data/sdk-versions.json';
Expand All @@ -25,20 +26,20 @@ export const SdkOverviewCards = () => {
{version && <span className={styles.versionChip}>v{version}</span>}
</div>
<div className={styles.cardLinks}>
<a href={`/develop/${id}`} className={styles.link}>
<Link to={`/develop/${id}`} className={styles.link}>
Developer guide
</a>
</Link>
<span className={styles.linkDivider} aria-hidden="true">
|
</span>
<a
href={apiReferenceHref}
<Link
to={apiReferenceHref}
className={styles.link}
target="_blank"
rel="noopener noreferrer"
>
API reference
</a>
</Link>
</div>
</div>
);
Expand Down