Skip to content

feat: apply transfer converters to System Nexus - #852

Draft
tconley1428 wants to merge 1 commit into
fix/system-nexus-payload-markerfrom
system-nexus-transfer-converter-context
Draft

feat: apply transfer converters to System Nexus#852
tconley1428 wants to merge 1 commit into
fix/system-nexus-payload-markerfrom
system-nexus-transfer-converter-context

Conversation

@tconley1428

Copy link
Copy Markdown
Contributor

Summary

  • scopes the System Nexus payload/failure converter context while serializing and deserializing outer System Nexus envelopes
  • uses a local unreleased nexgen build to generate .NET transfer-type converters and context-backed support helpers
  • generates a payload visitor for payload-bearing Workflow Service envelopes; any payload marked as a System Nexus envelope always bypasses the user codec

Status

Work in progress — do not merge yet. This PR must wait for the nexgen changes in temporalio/nexgen#128 to be released, then replace the local-generator integration with that released version.

There is also a server dependency: System Nexus result envelopes are not currently marked by the server. Until that behavior exists, codec coverage for marked result envelopes cannot be enabled; the end-to-end Signal-with-Start test intentionally uses no payload codec.

Validation

  • dotnet test tests/Temporalio.Tests/Temporalio.Tests.csproj --no-restore --filter 'FullyQualifiedName~SystemNexusPayloadConverterTests|FullyQualifiedName~SystemNexusTests'\n- dotnet format --verify-no-changes --no-restore (blocked only by pre-existing unused imports in tests/Temporalio.SimpleBench/Program.cs)\n- dotnet build --no-restore (blocked because tests/Temporalio.SimpleBench/obj/project.assets.json is absent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant