Add payload validation exception factory - #853
Conversation
| /// Factory for application failures that report invalid Nexus operation input from payload | ||
| /// conversion. | ||
| /// </summary> | ||
| public static class PayloadValidationException |
There was a problem hiding this comment.
This is not an exception class, so it should not be named *Exception. I would suggest renaming to PayloadValidationError and renaming the factory method to CreateException. Please update the change log to reflect this change too.
| @@ -0,0 +1,31 @@ | |||
| #pragma warning disable CA1711 // Factory naming matches the payload validation API across SDKs | |||
There was a problem hiding this comment.
This pragma will not be needed once the rename occurs.
| "Payload validation failed", | ||
| errorType: ErrorType, | ||
| nonRetryable: true, | ||
| details: details == null ? Array.Empty<object?>() : new object?[] { details }); |
There was a problem hiding this comment.
Every other SDK is producing one detail object unconditionally, regardless of details being null / None. Either this should match or the other SDKs corrected.
| @@ -144,6 +136,6 @@ public NexusPayloadSerializer(DataConverter dataConverter) => | |||
| private static bool IsPayloadValidationFailure(Exception e) => | |||
There was a problem hiding this comment.
I would recommend moving this to PayloadValidationError as an internal method. Since it creates the validation exception, it should also decide whether something is a validation exception or not.
3 participants
Payload converters and codecs can use this to report invalid Nexus operation input with structured details.