Stop sending deployment info for session per-worker task queue #2088
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| params.TaskQueue = sessionEnvironment.GetResourceSpecificTaskqueue() | ||
| // For the resource specific task queue, we don't need to include deployment options | ||
| // Save them to restore later | ||
| deployments := params.DeploymentOptions |
There was a problem hiding this comment.
Only disable versioning instead of removing the whole thing? better to keep the deployment name and build id if user has given it (to keep in the events).
There was a problem hiding this comment.
Does it make any difference for an activity only task queue? I don't see any difference in the history.
There was a problem hiding this comment.
we might add the deployment options in activity events later
Quinn-With-Two-Ns
force-pushed
the
SDK-4514
branch
from
eddebc9 to
5fc9d01
Compare
| } | ||
|
|
||
| func (ts *WorkerDeploymentTestSuite) TestBuildIDWithSession() { | ||
|
|
There was a problem hiding this comment.
Do we want to gate this? All other tests here have this req
if os.Getenv("DISABLE_SERVER_1_27_TESTS") != "" {
ts.T().Skip("temporal server 1.27+ required")
}
| wfHandle, err := ts.client.ExecuteWorkflow(ctx, ts.startWorkflowOptions("evolving-wf-1"), "SessionBuildIDWorkflow") | ||
| ts.NoError(err) | ||
|
|
||
| ts.NoError(wfHandle.Get(ctx, nil)) |
There was a problem hiding this comment.
What is this actually verifying? This seems to pass on master without your fix
There was a problem hiding this comment.
Should we be asserting that buildId and versioning settings for the session activity worker is properly set?
There was a problem hiding this comment.
Yeah I am verifying it still works and I didn't break anything.
Quinn-With-Two-Ns
force-pushed
the
SDK-4514
branch
from
5fc9d01 to
6ef51b0
Compare
4 participants
Stop sending deployment info for session per-worker task queue
Note
Temporarily disables deployment/versioning for the session activity worker on the resource-specific task queue (restored for creation worker) and adds a session build ID test.
newSessionWorker, saveparams.DeploymentOptions/params.UseBuildIDForVersioning, setDeploymentOptions.UseVersioning=falseandUseBuildIDForVersioning=falsefor the session activity worker on the resource-specific task queue, then restore for the creation worker.workerOverridesconstruction.TestBuildIDWithSessionintest/worker_deployment_test.goto validate running a session-enabled worker with deployment versioning; registers session workflow and activity usingactivity.RegisterOptionsand verifies workflow completion.Written by Cursor Bugbot for commit 6ef51b0. This will update automatically on new commits. Configure here.