Set default workflow task failure cause to unhandled failure #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unhandled exceptions previously lacked specific failure causes, making error categorization difficult in observability tools. Add WORKFLOW_TASK_FAILED_CAUSE_WORKFLOW_WORKER_UNHANDLED_FAILURE as default cause for unhandled exceptions, while preserving existing NonDeterministicException behavior. Improves error categorization. Fixes temporalio#2705
|
Looks good, started a CI run |
|
|
Hm not sure what happened, there was an issue with github runners around that time so I think that is the likely cause. It is passing now. To fix the other CI job please see #2686 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unhandled exceptions previously lacked specific failure causes, making
error categorization difficult in observability tools.
Add WORKFLOW_TASK_FAILED_CAUSE_WORKFLOW_WORKER_UNHANDLED_FAILURE as
default cause for unhandled exceptions, while preserving existing
NonDeterministicException behavior. Improves error categorization.
Fixes #2705
What was changed
Add default failure cause WORKFLOW_TASK_FAILED_CAUSE_WORKFLOW_WORKER_UNHANDLED_FAILURE for all exceptions except NonDeterministicException, which retains its existing specific cause.
Why?
This make Java SDK consistent with Go SDK and improves error categorization while maintaining backward compatibility.
Checklist
Closes
Default task failure cause to "workflow worker unhandled failure" #2705
How was this tested:
temporal-sdk/src/test/java/io/temporal/internal/replay/ReplayWorkflowTaskHandlerFailureCauseTest.java
Any docs updates needed?
No