fix findWnsDistributionPda fn #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelvanderwaal
requested review from
avoc-ado,
ilmoi,
nftechie and
richardwu
as code owners
nftechie
approved these changes
Nov 7, 2024
| [new PublicKey(collection).toBuffer()], | ||
| [ | ||
| new PublicKey(collection).toBuffer(), | ||
| paymentMint ? paymentMint.toBuffer() : SystemProgram.programId.toBuffer(), |
Contributor
There was a problem hiding this comment.
Did this second param get added recently? Or under the hood does it default to the system program if the payment mint isn't specified? Curious why we previously didn't have to specify the system program
Contributor
Author
There was a problem hiding this comment.
It's possible they changed the derivation of this after this code was written; there were a number of breaking changes to WNS during our original integration efforts. I verified in their source code this is the correct way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not blocking me; I'm just being a good citizen and fixing things.