Fix non-unique /tmp filenames in external library download scripts #3182
+36
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue where multiple users compiling tflite-micro simultaneously would encounter permission conflicts due to fixed temporary filenames. Changes: - Create unique temporary directories using username, PID, and timestamp - Implement automatic cleanup on all exit conditions Scripts modified: - tensorflow/lite/micro/tools/make/ext_libs/cmsis_download.sh - tensorflow/lite/micro/tools/make/ext_libs/cmsis_nn_download.sh - tensorflow/lite/micro/tools/make/ext_libs/eyalroz_printf_download.sh Fixes tensorflow#3042
|
Please add the following line to your PR description: |
ddavis-2015
suggested changes
Aug 22, 2025
Comment on lines
51
to
57
| # Create unique temporary directory name with username for better isolation | ||
| USERNAME=$(whoami 2>/dev/null || echo "unknown") | ||
| TEMP_DIR="/tmp/cmsis_dld_${USERNAME}_$(date +%s)_$$" | ||
| if ! mkdir -p "${TEMP_DIR}"; then | ||
| echo "ERROR: Failed to create temporary directory ${TEMP_DIR}" >&2 | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
I would suggest something more akin to the following:
TEMP_DIR=$(mktemp -d /tmp/$(basename $0 .sh).XXXXXX)
Comment on lines
56
to
62
| # Create unique temporary directory name with username for better isolation | ||
| USERNAME=$(whoami 2>/dev/null || echo "unknown") | ||
| TEMP_DIR="/tmp/cmsis_nn_dld_${USERNAME}_$(date +%s)_$$" | ||
| if ! mkdir -p "${TEMP_DIR}"; then | ||
| echo "ERROR: Failed to create temporary directory ${TEMP_DIR}" >&2 | ||
| exit 1 | ||
| fi |
Comment on lines
50
to
56
| # Create unique temporary directory name with username for better isolation | ||
| USERNAME=$(whoami 2>/dev/null || echo "unknown") | ||
| TEMP_DIR="/tmp/eyalroz_dld_${USERNAME}_$(date +%s)_$$" | ||
| if ! mkdir -p "${TEMP_DIR}"; then | ||
| echo "ERROR: Failed to create temporary directory ${TEMP_DIR}" >&2 | ||
| exit 1 | ||
| fi |
|
@ilya-kupchenko Thank you for your interest in TFLM. It is greatly appreciated that you have submitted a PR for this issue. |
…mp-filename-collision
Address maintainer feedback to use mktemp instead of custom naming. This provides better atomicity and security while maintaining shorter paths for embedded system compatibility. - Replace custom temp dir naming with mktemp -d Addresses feedback in tensorflow#3042
ddavis-2015
approved these changes
Sep 2, 2025
veblush
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
bug=fixes #3042
Problem
Multiple users or processes compiling tflite-micro simultaneously encounter permission conflicts due to fixed temporary filenames in
/tmp.Solution
Files Modified
Testing
Tested with multiple concurrent users - no more /tmp conflicts.