Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the example plugin #8

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Jan 7, 2025

@dominiklohmann dominiklohmann added the enhancement An improvement of existing code label Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • CMakeLists.txt: Language not supported
  • Dockerfile: Language not supported
  • builtins/operators/read_custom_log.cpp: Language not supported
  • integration/data/reference/tests/test_parse_example_logs/step_00.ref: Language not supported
  • integration/data/reference/tests/test_trim_strings/step_00.ref: Language not supported
  • integration/data/reference/tests/test_trim_strings/step_01.ref: Language not supported
  • integration/data/reference/tests/test_trim_strings/step_02.ref: Language not supported
  • integration/data/reference/tests/test_trimming_non-2dstring_fields_fails/step_00.ref: Language not supported
  • integration/tests/setup_suite.bash: Language not supported
  • integration/tests/tests.bats: Language not supported
  • src/plugin.cpp: Language not supported
Comments suppressed due to low confidence (1)

README.md:3

  • The word 'operaotr' is misspelled. It should be 'operator'.
This is an example plugin for Tenzir, adding a `trim` operaotr that removes
@dominiklohmann dominiklohmann force-pushed the topic/revamp-example-plugin branch from cd66162 to a50c756 Compare January 7, 2025 18:00
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the compile cycle, but the annotated source code reads excellent!

@IyeOnline IyeOnline force-pushed the topic/revamp-example-plugin branch from b488dc0 to 01e6436 Compare January 8, 2025 09:31
@IyeOnline IyeOnline force-pushed the topic/revamp-example-plugin branch from 01e6436 to 5c58198 Compare January 8, 2025 09:32
@dominiklohmann dominiklohmann merged commit 0053af5 into main Jan 8, 2025
2 checks passed
@dominiklohmann dominiklohmann deleted the topic/revamp-example-plugin branch January 8, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants